Skip to content

Fix issue #611 (exception thrown if shapes and an overlaid axis) #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2016
Merged

Fix issue #611 (exception thrown if shapes and an overlaid axis) #612

merged 2 commits into from
Jun 7, 2016

Conversation

n-riesco
Copy link
Contributor

@n-riesco n-riesco commented Jun 7, 2016

No description provided.

n-riesco added 2 commits June 7, 2016 16:07
@n-riesco
test: issue plotly#611
b5f8707 
* A plot with shapes and an overlaid axis should not throw an exception.
@n-riesco
shapes: fix plotly#611 (shapes and overlaid axis)
be61173 
* Only draw shapes in main subplots.
@mdtusz
Copy link
Contributor

mdtusz commented Jun 7, 2016

Looks ok to me!

💃

@etpinard etpinard added bug something broken and removed type: maintenance labels Jun 7, 2016
@etpinard
Copy link
Contributor

etpinard commented Jun 7, 2016

Thanks @n-riesco !

@etpinard etpinard merged commit 21b0341 into plotly:master Jun 7, 2016
@n-riesco n-riesco deleted the fix-issue-611-exception-with-shapes-and-two-y-axes branch June 10, 2016 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n-riesco @mdtusz @etpinard